connection: fix getpid() call on disconnect #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous fix only handled the connections from `Valkey` class, which left classes like `Sentinel` broken because those are handled in `AbstractConnection`. Also after merging previous fix I was pointed to the place in Python standard library where the similar issue was handled by having `from os import getpid` instead of having a local object assigned to `os.getpid`. Fixes valkey-io#158 Signed-off-by: Mikhail Koviazin <[email protected]>
mkmkme
requested review from
aiven-sal,
ahmedsobeh,
smeso and
bogdanp05
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
==========================================
- Coverage 76.23% 76.22% -0.01%
==========================================
Files 130 130
Lines 33947 33946 -1
==========================================
- Hits 25879 25877 -2
- Misses 8068 8069 +1 ☔ View full report in Codecov by Sentry. |
bogdanp05
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous fix only handled the connections from
Valkeyclass, which left classes likeSentinelbroken because those are handled inAbstractConnection.Also after merging previous fix I was pointed to the place in Python standard library where the similar issue was handled by having
from os import getpidinstead of having a local object assigned toos.getpid.Fixes #158
Pull Request check-list
Description of change